[lld] r192415 - Use switch instead of if, and handle all enum values.

Shankar Easwaran shankare at codeaurora.org
Thu Oct 10 21:11:41 PDT 2013


On 10/10/2013 10:48 PM, Rui Ueyama wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=192415&view=rev
> Log:
> Use switch instead of if, and handle all enum values.
Thanks for cleaning this up!
> Modified: lld/trunk/lib/Core/Resolver.cpp
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/Resolver.cpp?rev=192415&r1=192414&r2=192415&view=diff
> ==============================================================================
> --- lld/trunk/lib/Core/Resolver.cpp (original)
> +++ lld/trunk/lib/Core/Resolver.cpp Thu Oct 10 22:48:06 2013
> @@ -289,29 +289,41 @@ void Resolver::addAtoms(const std::vecto
>     }
>   }
>   
> -// ask symbol table if any definitionUndefined atoms still exist
> -// if so, keep searching libraries until no more atoms being added
> +// Ask symbol table if any undefined atoms still exist. If so, keep searching
> +// libraries until no more atoms being added.
This coment is wrong, and reflects before nextFile existed.

Shankar Easwaran

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation




More information about the llvm-commits mailing list