XCore target: fix bug in XCoreLowerThreadLocal.cpp

Richard Osborne richard at xmos.com
Wed Oct 9 08:36:07 PDT 2013


Looks good to me.

On 02/10/13 17:13, Robert Lytton wrote:
> I've amended the patch.
> For phi node handling the predecessor block is checked for multiple successors and if so the edge is first split.
>
>      XCore target: fix bug in XCoreLowerThreadLocal.cpp
>      
>      When a ConstantExpr which uses a thread local is part of a PHI node
>      instruction, the insruction that replaces the ConstantExpr must
>      be inserted in the predecessor block, in front of the terminator instruction.
>      If the predecessor block has multiple successors, the edge is first split.
>
> Good to go?
>
> Robert
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits


-- 
Richard Osborne | XMOS
http://www.xmos.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131009/6a71bb1e/attachment.html>


More information about the llvm-commits mailing list