[PATCH] [Layout] Assign ordinals in resolution order

[Shankar Easwaran]

On 10/9/2013 12:17 AM, Rui Ueyama wrote:
>
> ================
> Comment at: lib/Core/Resolver.cpp:302
> @@ -299,1 +301,3 @@
> +    if (nextFile->kind() == File::kindObject) {
> +      nextFile->setOrdinal(_context.getNextOrdinalAndIncrement());
>         handleFile(*nextFile);
> ----------------
> Shankar Kalpathi Easwaran wrote:
>> Rui Ueyama wrote:
>>> Don't you need to check if an ordinal has already been assigned?
>> no there is no need do that for files. If its an object file, the resolver shouldnt see the same file again.
> I'd think there's no such guarantee. For example, for --{start,end}-group, resolver would see the files in a group multiple times, no?
>
No, not files which are kindObject. If it sees its a bug. You will get 
symbols that the resolver would say that would be multiply defined.

Thanks

Shankar Easwaran

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation