[patch] Add a TargetMCStreamer interface.

[Quentin Colombet]

Hi Rafael,

On Oct 8, 2013, at 6:13 AM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:

> On 7 October 2013 18:02, Quentin Colombet <qcolombet at apple.com> wrote:
>> Hi Rafael,
>> 
>> The refactoring you are doing is interesting, although it LGTM, I believe it
>> would be useful to discuss it on LLVMDev.
> 
> I committed it as r192181. I will send an email with instructions on
> how to use it.
> 
>> More over, I think it would be great if your patch could document the new
>> pattern for doing target specific MCStreamer related thing (I do not know
>> what would be the right place though). Indeed, when looking at the patch is
>> quite obvious how to use it, but in one month, staring at the MC API, I
>> think it would not be that easy :).
> 
> Good point. The best I could think of is a large comment in
> MCStreamer.h. Let me know if you think it should be moved somewhere
> else.
A large comment in MCStreamer.h is great.
Additionally, you should add this information in the CodeGenerator document (http://llvm.org/docs/CodeGenerator.html) within the MC Layer.

Thanks,
-Quentin
> 
>> Minor comment:
>> - You may want to change the name of the TargetMCStreamer to
>> MCTargetStreamer to keep the name consistent.
> 
> Done.
> 
> Cheers,
> Rafael