[PATCH] [lld][inputGraph] Implement flavor specific resolver

Shankar Kalpathi Easwaran shankarke at gmail.com
Mon Oct 7 21:25:12 PDT 2013



================
Comment at: include/lld/Driver/InputGraph.h:330
@@ +329,3 @@
+/// \brief Represents Internal Input files
+class SimpleFileNode : public InputElement {
+public:
----------------
Rui Ueyama wrote:
> Shankar Kalpathi Easwaran wrote:
> > Rui Ueyama wrote:
> > > Shankar Kalpathi Easwaran wrote:
> > > > Rui Ueyama wrote:
> > > > > Does SimpleFileNode contains multiple files? The name is confusing.
> > > > It resembles SimpleFile. It does contain multiple files, but is usually a place holder for files that are internally added by the Linker. See Driver. 
> > > > 
> > > I'd name it SimpleArchiveFileNode.
> > Its not intended for Archives. Its intended for any internal file that you want to add. For example ImplicitFiles/InternalFiles.
> A file containing multiple files is usually called an archive no? It may or may not correspond to an .a file on disk, but it doesn't matter.
The intention is to have a method to add linker internal files. I dont want to give this a SimpleArchiveFileNode, which doesnot reflect what is being done. For that reason FileNode too could contain multiple files used to implement whole archives etc.


http://llvm-reviews.chandlerc.com/D1830



More information about the llvm-commits mailing list