[PATCH] Remove "localize global" optimization

Chandler Carruth chandlerc at google.com
Mon Oct 7 17:09:42 PDT 2013


On Mon, Oct 7, 2013 at 4:27 PM, Jim Grosbach <grosbach at apple.com> wrote:

> Good thoughts, Chandler. Do I understand you correctly that you agree with
> Evan’s statement with the modification of s/committed/enabled by default/?


Essentially, although I tried to be a bit more clear about which buckets
different optimizations fall into. For example, in this case, I don't think
this change would would have fallen into the bucket where you really need
to give some significant heads up prior to enabling by default.

I think the problem is this case was very different -- the people making
the change *knew* there were a small number of important benchmarks that
regressed, and failing to address that prior to enabling or committing
something is quite different.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131007/00ecfc03/attachment.html>


More information about the llvm-commits mailing list