[PATCH] Remove "localize global" optimization

[Chandler Carruth]

On Wed, Oct 2, 2013 at 10:08 AM, Bob Wilson <bob.wilson at apple.com> wrote:

> On Oct 2, 2013, at 8:33 AM, Alexey Samsonov <samsonov at google.com> wrote:
>
>
> On Tue, Oct 1, 2013 at 10:39 PM, Bob Wilson <bob.wilson at apple.com> wrote:
>
>>
>> On Oct 1, 2013, at 10:20 AM, Nick Lewycky <nlewycky at gmail.com> wrote:
>>
>> >
>> >  The optimization was "important" for some SPEC test, but I think we're
>> past caring about that.
>>
>> Not necessarily.  Has anyone measured the impact on SPEC and other
>> benchmarks?
>>
>
> I'm going to submit this anyway.
>
>
> That's not very friendly.  You may not care about SPEC but that doesn't
> mean that no one else cares.
>

Alexey, why has there been no response here? ANd why did you just submit
this anyway?

I don't think this is the right way to interact with the community. Someone
expressed a real, well reasoned argument why we shouldn't take the path you
were pursuing forward, and you took it anyways without giving any
explanation. Don't do this.

If you urgently need to fix the *correctness* problem here, then fix that
in a narrow way. Unilaterally removing this issue doesn't seem justifiable
as an urgent quick-fix.

I hope that you reply soon with an explanation, and preferably restoring at
least the prior behavior that others were relying on.
-Chandler
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131007/957502d2/attachment.html>