[PATCH] Add a 'covers' operation to LiveRange
Andrew Trick
atrick at apple.com
Mon Oct 7 15:23:55 PDT 2013
On Oct 7, 2013, at 3:15 PM, Matthias Braun <mbraun at apple.com> wrote:
> And another one with an actually new patch…
>
> <Add-a-covers-operation-to-LiveRange.patch>
LGTM! -Andy
> On Oct 7, 2013, at 3:12 PM, Matthias Braun <mbraun at apple.com> wrote:
>
>> And another version without typos.
>>
>> Greetings
>> Matthias
>>
>> <Add-a-covers-operation-to-LiveRange.patch>
>> On Oct 7, 2013, at 3:02 PM, Matthias Braun <mbraun at apple.com> wrote:
>>
>>>
>>> On Oct 7, 2013, at 2:34 PM, Andrew Trick <atrick at apple.com> wrote:
>>>
>>>>
>>>> On Oct 7, 2013, at 1:57 PM, Matthias Braun <mbraun at apple.com> wrote:
>>>>
>>>>> <Add-a-covers-operation-to-LiveRange.patch>
>>>>
>>>> + const_iterator I = begin();
>>>> + for (const_iterator O = Other.begin(), OE = Other.end(); O != OE; ++O) {
>>>> + I = advanceTo(I, O->start);
>>>>
>>>> Is it possible for advanceTo to return end() here?
>>> Indeed. An improved version with more comments is attached.
>>>
>>> Greetings
>>> Matthias
>>>
>>> <Add-a-covers-operation-to-LiveRange.patch>_______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
More information about the llvm-commits
mailing list