[patch] Add a TargetMCStreamer interface.

[Quentin Colombet]

Hi Rafael,

The refactoring you are doing is interesting, although it LGTM, I believe it would be useful to discuss it on LLVMDev.
More over, I think it would be great if your patch could document the new pattern for doing target specific MCStreamer related thing (I do not know what would be the right place though). Indeed, when looking at the patch is quite obvious how to use it, but in one month, staring at the MC API, I think it would not be that easy :).

Minor comment:
- You may want to change the name of the TargetMCStreamer to MCTargetStreamer to keep the name consistent.

Cheers,
-Quentin

On Oct 7, 2013, at 1:24 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:

> This patch fixes an old FIXME by creating a TargetMCStreamer interface
> and moving the target specific functions for ARM, Mips and PPC to it.
> 
> The ARM streamer is still declared in a common place because it is
> used from lib/CodeGen/ARMException.cpp, but the Mips and PPC are
> completely hidden in the corresponding Target directories.
> 
> Cheers,
> Rafael
> <t.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131007/2b453fb8/attachment.html>