[PATCH] [ARM] Improve build attributes emission

[Richard Barton]

  Two small comments. Happy for you to commit with those changes.


================
Comment at: lib/Target/ARM/ARMAsmPrinter.cpp:745
@@ +744,3 @@
+                                            const ARMSubtarget *Subtarget) {
+  if (CPU == "xscale")
+    return ARMBuildAttrs::v5TEJ;
----------------
I think you should put a comment in to say why xscale/v5TEJ is treated as a special case.

================
Comment at: test/CodeGen/ARM/2010-09-29-mc-asm-header-test.ll:134
@@ +133,3 @@
+; CORTEX-R5:  .eabi_attribute 9, 2
+; CORTEX-R5:  .eabi_attribute 10, 3
+; CORTEX-R5:  .fpu vfpv3
----------------
VFPv3 needs the same fix as VFPv4 for _D16 version. This value then becomes 4.


http://llvm-reviews.chandlerc.com/D1811