Suggesting elimination of unused Target implementation members

Rafael EspĂ­ndola rafael.espindola at gmail.com
Sun Oct 6 07:34:38 PDT 2013


LGTM!

Thanks. Do you have commit access?

On 5 October 2013 16:24, MathOnNapkins . <mathonnapkins at gmail.com> wrote:
> Dear All,
>
> While researching the existing targets I noticed that
> getEHExceptionRegister() and getEHHandlerRegister() are not called anywhere
> in the source tree (presumably used to be defined in TargetRegisterInfo.h as
> a pure virtual?) Several targets still implement and declare member
> functions with these names, and only one of them (PowerPC) does anything
> meaningful. So, unless they're being kept around for posterity or future
> use, I would venture to say that they're just taking up space. I've included
> a patch that removes them.
>
> Thanks for reading,
> ~MoN / Dave
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list