[PATCH] [ARM] Improve build attributes emission

Renato Golin renato.golin at linaro.org
Fri Oct 4 03:28:05 PDT 2013


LGTM


On 4 October 2013 08:50, Amara Emerson <amara.emerson at arm.com> wrote:

>   Fixed v6S-M issue and added more tests to cover v6, v6m, v6t2, v7EM, v7M.
>
>   I also noticed that the Tag_DIV_use attribute was being emitted the
> wrong way around. I've added some more enums to make it clearer. The ABI
> addenda says that DIV_use value 2 should only be used when hardware divide
> is available in ARM mode.
>
> http://llvm-reviews.chandlerc.com/D1811
>
> CHANGE SINCE LAST DIFF
>   http://llvm-reviews.chandlerc.com/D1811?vs=4605&id=4661#toc
>
> Files:
>   lib/Target/ARM/ARMAsmPrinter.cpp
>   lib/Target/ARM/ARMBuildAttrs.h
>   test/CodeGen/ARM/2010-09-29-mc-asm-header-test.ll
>   test/CodeGen/ARM/2010-10-19-mc-elf-objheader.ll
>   test/MC/ARM/xscale-attributes.ll
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131004/b4463db8/attachment.html>


More information about the llvm-commits mailing list