[lld] r191924 - [ELF] Fix uninitalized value.

[Michael J. Spencer]

Author: mspencer
Date: Thu Oct  3 14:25:34 2013
New Revision: 191924

URL: http://llvm.org/viewvc/llvm-project?rev=191924&view=rev
Log:
[ELF] Fix uninitalized value.

Modified:
    lld/trunk/lib/ReaderWriter/ELF/File.h
    lld/trunk/test/elf/X86_64/largebss.test
    lld/trunk/test/elf/phdr.test
    lld/trunk/test/elf/quickdata.test
    lld/trunk/test/elf/sections.test

Modified: lld/trunk/lib/ReaderWriter/ELF/File.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/File.h?rev=191924&r1=191923&r2=191924&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/File.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/File.h Thu Oct  3 14:25:34 2013
@@ -278,6 +278,7 @@ public:
     if (SymI != SymE)
       ++SymI;
 
+    int commonOrd = 0;
     for (; SymI != SymE; ++SymI) {
       const Elf_Shdr *section = _objFile->getSection(&*SymI);
 
@@ -302,6 +303,7 @@ public:
       } else if (isCommonSymbol(&*SymI)) {
         auto *newAtom = new (_readerStorage)
           ELFCommonAtom<ELFT>(*this, *symbolName, &*SymI);
+        newAtom->setOrdinal(commonOrd++);
         _definedAtoms._atoms.push_back(newAtom);
         _symbolToAtomMapping.insert(std::make_pair(&*SymI, newAtom));
       } else {

Modified: lld/trunk/test/elf/X86_64/largebss.test
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf/X86_64/largebss.test?rev=191924&r1=191923&r2=191924&view=diff
==============================================================================
--- lld/trunk/test/elf/X86_64/largebss.test (original)
+++ lld/trunk/test/elf/X86_64/largebss.test Thu Oct  3 14:25:34 2013
@@ -5,16 +5,16 @@
 
 RUN: lld -flavor gnu -target x86_64 %p/Inputs/largebss.o --output-filetype=yaml --noinhibit-exec | FileCheck %s
 
-CHECK:  - name:            largebss
+CHECK:  - name:            largecommon
 CHECK:    scope:           global
 CHECK:    type:            zero-fill
 CHECK:    size:            4000
+CHECK:    merge:           as-tentative
 CHECK:    section-name:    .bss
-CHECK:  - name:            largecommon
+CHECK:  - name:            largebss
 CHECK:    scope:           global
 CHECK:    type:            zero-fill
 CHECK:    size:            4000
-CHECK:    merge:           as-tentative
 CHECK:    section-name:    .bss
 CHECK:  - name:            largetbss
 CHECK:    scope:           global

Modified: lld/trunk/test/elf/phdr.test
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf/phdr.test?rev=191924&r1=191923&r2=191924&view=diff
==============================================================================
--- lld/trunk/test/elf/phdr.test (original)
+++ lld/trunk/test/elf/phdr.test Thu Oct  3 14:25:34 2013
@@ -63,7 +63,7 @@ I386-NEXT:     Offset: 0x4000
 I386-NEXT:     VirtualAddress: 0x4000
 I386-NEXT:     PhysicalAddress: 0x4000
 I386-NEXT:     FileSize: 4
-I386-NEXT:     MemSize: 16389
+I386-NEXT:     MemSize: 16392
 I386-NEXT:     Flags [ (0x6)
 I386-NEXT:       PF_R (0x4)
 I386-NEXT:       PF_W (0x2)

Modified: lld/trunk/test/elf/quickdata.test
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf/quickdata.test?rev=191924&r1=191923&r2=191924&view=diff
==============================================================================
--- lld/trunk/test/elf/quickdata.test (original)
+++ lld/trunk/test/elf/quickdata.test Thu Oct  3 14:25:34 2013
@@ -4,11 +4,12 @@ RUN: --noinhibit-exec | FileCheck %s -ch
 hexagon:  - name:            init
 hexagon:    scope:           global
 hexagon:    type:            quick-data
-hexagon:  - name:            bss1
-hexagon:    scope:           global
-hexagon:    type:            zero-fill-quick
 hexagon:  - name:            ac1
 hexagon:    scope:           global
 hexagon:    type:            zero-fill-quick
 hexagon:    size:            1
 hexagon:    merge:           as-tentative
+hexagon:  - name:            bss1
+hexagon:    scope:           global
+hexagon:    type:            zero-fill-quick
+

Modified: lld/trunk/test/elf/sections.test
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf/sections.test?rev=191924&r1=191923&r2=191924&view=diff
==============================================================================
--- lld/trunk/test/elf/sections.test (original)
+++ lld/trunk/test/elf/sections.test Thu Oct  3 14:25:34 2013
@@ -10,7 +10,7 @@ OBJDUMP:  1 .text         0000000a 00000
 OBJDUMP:  2 .data         00000004 0000000000001000 DATA
 OBJDUMP:  3 .special      00000004 0000000000001004 DATA
 OBJDUMP:  4 .anotherspecial 00000004 0000000000001008 DATA
-OBJDUMP:  5 .bss          00000001 000000000000100c BSS
+OBJDUMP:  5 .bss          00000004 000000000000100c BSS
 OBJDUMP:  6 .shstrtab     {{[0-9a-f]+}} 0000000000000000
 OBJDUMP:  7 .symtab       {{[0-9a-f]+}} 0000000000000000
 OBJDUMP:  8 .strtab       {{[0-9a-f]+}} 0000000000000000
@@ -90,7 +90,7 @@ READOBJ:       SHF_ALLOC
 READOBJ:       SHF_WRITE
 READOBJ:     ]
 READOBJ:     Address: 0x100C
-READOBJ:     Size: 1
+READOBJ:     Size: 4
 READOBJ:   }
 READOBJ:   Section {
 READOBJ:     Index: 6