[llvm] r191792 - Debug Info: remove duplication of DIEs when a DIE is part of the type system

[David Blaikie]

On Thu, Oct 3, 2013 at 11:14 AM, Adrian Prantl <aprantl at apple.com> wrote:

>
> Am 02.10.2013 um 17:55 schrieb Eric Christopher <echristo at gmail.com>:
>
> >>
> >>>
> >>> I would like to revisit this (maybe revert this) later on when type
> units
> >>> are working.
> >>
> >>
> >> I'd rather revert this before type units (& then revisit this
> afterwards) as
> >> it may complicate the type unit work. I think the extra benefit (using
> >> direct ref_addr, rather than signatures) of this approach over type
> units
> >> may be implementable via an incremental improvement to type units.
> >>
> >
> > FWIW I've been following along with the thread and agree here. David
> > is actively working on type units and we should have something here
> > shortly. Let's let that work proceed and revert this for now.
>
> Just curious, what kind of time frame are we talking about here?


I sent a prototype out to llvm-dev on Monday. It's incomplete and not the
right design (I was just trying to see how it might work - a "throw the
first one away" if you will). From Eric's feedback I've a few small fixes
and cleanups to commit separately (some of which should duly require
separate test cases to be created which takes me a bit of time), some MC
improvements/fixes to be made (that's still a bit of a struggle, trying to
figure out how to implement multiple grouped comdat sections with the same
section name, but I'll get there), and the refactoring to a commitable
design - but I figure probably by the end of next week.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131003/449abdb5/attachment.html>