[PATCH] Don't use runtime bounds check between different address space pointers

Nadav Rotem nrotem at apple.com
Tue Oct 1 20:30:54 PDT 2013


Hi Matt, 

Is this a real problem on R600 ?  The patch LGTM.   I did not understand the comment about the Parallel annotation. 

Thanks,
Nadav


On Oct 1, 2013, at 7:14 PM, Matt Arsenault <Matthew.Arsenault at amd.com> wrote:

> Hi nadav,
> 
> Don't vectorize with a runtime check if it requires a comparison between pointers with different address spaces. The values can't be assumed to be directly comparable. Previously it would create an illegal bitcast.
> 
> http://llvm-reviews.chandlerc.com/D1804
> 
> Files:
>  lib/Transforms/Vectorize/LoopVectorize.cpp
>  test/Transforms/LoopVectorize/runtime-check-address-space.ll
>  test/Transforms/LoopVectorize/runtime-check-readonly-address-space.ll
> <D1804.1.patch>




More information about the llvm-commits mailing list