[llvm] r191786 - Don't merge tiny functions.

[Matt Arsenault]

Author: arsenm
Date: Tue Oct  1 13:05:30 2013
New Revision: 191786

URL: http://llvm.org/viewvc/llvm-project?rev=191786&view=rev
Log:
Don't merge tiny functions.

It's silly to merge functions like these:

define void @foo(i32 %x) {
  ret void
}

define void @bar(i32 %x) {
  ret void
}

to get

define void @bar(i32) {
  tail call void @foo(i32 %0)
  ret void
}

Added:
    llvm/trunk/test/Transforms/MergeFunc/too-small.ll
Modified:
    llvm/trunk/lib/Transforms/IPO/MergeFunctions.cpp
    llvm/trunk/test/Transforms/MergeFunc/merge-ptr-and-int.ll

Modified: llvm/trunk/lib/Transforms/IPO/MergeFunctions.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/MergeFunctions.cpp?rev=191786&r1=191785&r2=191786&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/IPO/MergeFunctions.cpp (original)
+++ llvm/trunk/lib/Transforms/IPO/MergeFunctions.cpp Tue Oct  1 13:05:30 2013
@@ -836,6 +836,18 @@ bool MergeFunctions::insert(ComparableFu
 
   const ComparableFunction &OldF = *Result.first;
 
+  // Don't merge tiny functions, since it can just end up making the function
+  // larger.
+  // FIXME: Should still merge them if they are unnamed_addr and produce an
+  // alias.
+  if (NewF.getFunc()->size() == 1) {
+    if (NewF.getFunc()->front().size() <= 2) {
+      DEBUG(dbgs() << NewF.getFunc()->getName()
+            << " is to small to bother merging\n");
+      return false;
+    }
+  }
+
   // Never thunk a strong function to a weak function.
   assert(!OldF.getFunc()->mayBeOverridden() ||
          NewF.getFunc()->mayBeOverridden());

Modified: llvm/trunk/test/Transforms/MergeFunc/merge-ptr-and-int.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/MergeFunc/merge-ptr-and-int.ll?rev=191786&r1=191785&r2=191786&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/MergeFunc/merge-ptr-and-int.ll (original)
+++ llvm/trunk/test/Transforms/MergeFunc/merge-ptr-and-int.ll Tue Oct  1 13:05:30 2013
@@ -1,18 +1,27 @@
 ; RUN: opt -S -mergefunc < %s | FileCheck %s
 target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
 
-; CHECK-LABEL: f0
+
+declare void @stuff()
+
+; CHECK-LABEL: @f0(
 define void @f0(i64 %p0) {
 entry:
+  call void @stuff()
+  call void @stuff()
+  call void @stuff()
   ret void
 }
 
-; CHECK-LABEL: f1
+; CHECK-LABEL: @f1(
 ; CHECK: ptrtoint i64*
 ; CHECK: tail call void @f0(i64
 
 define void @f1(i64* %p0) {
 entry:
+  call void @stuff()
+  call void @stuff()
+  call void @stuff()
   ret void
 }
 

Added: llvm/trunk/test/Transforms/MergeFunc/too-small.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/MergeFunc/too-small.ll?rev=191786&view=auto
==============================================================================
--- llvm/trunk/test/Transforms/MergeFunc/too-small.ll (added)
+++ llvm/trunk/test/Transforms/MergeFunc/too-small.ll Tue Oct  1 13:05:30 2013
@@ -0,0 +1,14 @@
+; RUN: opt -S -mergefunc < %s | FileCheck %s
+
+define void @foo(i32 %x) {
+; CHECK-LABEL: @foo(
+; CHECK-NOT: call
+  ret void
+}
+
+define void @bar(i32 %x) {
+; CHECK-LABEL: @bar(
+; CHECK-NOT: call
+  ret void
+}
+