[llvm] r191715 - Forgot to add a break statement.

[Dimitry Andric]

Hi Preston,

I would suggest putting another break statement after the X86::ADD16rr(_DB) case label.  It is currently superfluous, but it might prevent a mistake in the future, if another case label is ever added. :-)

-Dimitry

On Oct 1, 2013, at 01:51, Preston Gurd <preston.gurd at intel.com> wrote:

> Author: pgurd
> Date: Mon Sep 30 18:51:22 2013
> New Revision: 191715
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=191715&view=rev
> Log:
> Forgot to add a break statement.
> 
> 
> Modified:
>    llvm/trunk/lib/Target/X86/X86FixupLEAs.cpp
> 
> Modified: llvm/trunk/lib/Target/X86/X86FixupLEAs.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FixupLEAs.cpp?rev=191715&r1=191714&r2=191715&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/X86FixupLEAs.cpp (original)
> +++ llvm/trunk/lib/Target/X86/X86FixupLEAs.cpp Mon Sep 30 18:51:22 2013
> @@ -125,6 +125,7 @@ FixupLEAPass::postRAConvertToLEA(Machine
>       // which requires isImm() to be true
>       return 0;
>     }
> +    break;
>   case X86::ADD16rr:
>   case X86::ADD16rr_DB:
>     if (MI->getOperand(1).getReg() != MI->getOperand(2).getReg()) {
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 203 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131001/42a89ca8/attachment.sig>