[PATCH] [PATCH] Teach the Inliner about attribute optnone

Andrea_DiBiagio at sn.scee.net Andrea_DiBiagio at sn.scee.net
Mon Sep 30 07:40:53 PDT 2013


Hi Chandler,

Before you do take a look at this patch, I'd recommend looking at the 
related discussion going on here: 
http://comments.gmane.org/gmane.comp.compilers.llvm.cvs/156328
[llvm] r189101 - Add function attribute 'optnone'.

Not everybody likes the idea of having attribute optnone; any input you 
might have on that topic would be gratefully received.

If the consensus is that we shouldn't add this feature then I will revert 
the change.

Thanks, 
Andrea Di Biagio

Chandler Carruth <chandlerc at google.com> wrote on 17/09/2013 11:37:46:

> From: Chandler Carruth <chandlerc at google.com>
> To: reviews+D1642+public+cbff8fbf4d9466f0 at llvm-reviews.chandlerc.com, 
> Cc: Andrea_DiBiagio at sn.scee.net, Commit Messages and Patches for 
> LLVM <llvm-commits at cs.uiuc.edu>
> Date: 17/09/2013 11:37
> Subject: Re: [PATCH] [PATCH] Teach the Inliner about attribute optnone
> 
> I'll review this in a day or two. Sorry for delays. Feel free to 
> ping me directly if necessary.
> 
> One high level comment: I think it is reasonable for optnone to 
> imply noinline, but I think you should document that fact.
> 

> On Tue, Sep 17, 2013 at 3:10 AM, Andrea Di Biagio 
<Andrea_DiBiagio at sn.scee.net
> > wrote:
> 
>   Friendly ping.
> 
> http://llvm-reviews.chandlerc.com/D1642
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

**********************************************************************
This email and any files transmitted with it are confidential and intended 
solely for the use of the individual or entity to whom they are addressed. 
If you have received this email in error please notify postmaster at scee.net
This footnote also confirms that this email message has been checked for 
all known viruses.
Sony Computer Entertainment Europe Limited
Registered Office: 10 Great Marlborough Street, London W1F 7LP, United 
Kingdom
Registered in England: 3277793
**********************************************************************

P Please consider the environment before printing this e-mail



More information about the llvm-commits mailing list