[PATCH] llvm-objdump: Dump COFF import table if -private-headers option is given.

[Rui Ueyama]

Thanks, Sean. Looks like we should rename all the getXXX{Begin,End}
functions in this file at once. Is there any concern on doing that? If
none, I'll do that in a different patch.


On Thu, Sep 26, 2013 at 4:38 PM, Sean Silva <silvas at purdue.edu> wrote:

> We actually have this in the coding standard:
>
> http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
>  :
>
> As an exception, classes that mimic STL classes can have member names in
> STL’s style of lower-case words separated by underscores (e.g. begin(),
> push_back(), and empty()). Classes that provide multiple iterators should
> add a singular prefix to begin() and end() (e.g. global_begin() and
> use_begin()).
>
> I.e. import_directory_begin (it returns an import_directory_iterator so I
> guess that import_directory_* is the prefix)
>
> -- Sean Silva
>
>
>
> On Thu, Sep 26, 2013 at 7:21 PM, Rui Ueyama <ruiu at google.com> wrote:
>
>>
>>
>> ================
>> Comment at: include/llvm/Object/COFF.h:298-299
>> @@ -289,1 +297,4 @@
>>
>> +  import_directory_iterator getImportDirectoryBegin() const;
>> +  import_directory_iterator getImportDirectoryEnd() const;
>> +
>> ----------------
>> Michael Spencer wrote:
>> > LLVM uses <type>_{begin,end} for these.
>> Looks like _{begin,end} is used only when the prefix is not in camel
>> case.  We already have two different styles of naming (getSectionRelBegin
>> and begin_symbols, for examples). I don't have a preference on that, so if
>> you prefer one over the others, I'll rename them.
>>
>>
>> http://llvm-reviews.chandlerc.com/D1719
>>
>> BRANCH
>>   readobj
>>
>> ARCANIST PROJECT
>>   llvm
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130926/f0164623/attachment.html>