[PATCH] llvm-objdump: Dump COFF import table if -private-headers option is given.

Rui Ueyama ruiu at google.com
Thu Sep 26 16:32:25 PDT 2013



================
Comment at: include/llvm/Object/COFF.h:348
@@ +347,3 @@
+private:
+  DataRefImpl ImportDirectoryPimpl;
+  const COFFObjectFile *OwningObject;
----------------
Michael Spencer wrote:
> This doesn't need to use the DataRefImpl crazyness as it's a COFF specific interface.
In order to provide a simliar API like increment(), I had to use content_iterator. And content_iterator class depends on that craziness to some degree. So it was easier to implement this in the same way as for the other data than skipping that DataRefImpl stuff.


http://llvm-reviews.chandlerc.com/D1719

BRANCH
  readobj

ARCANIST PROJECT
  llvm



More information about the llvm-commits mailing list