[PATCH] Don't localize globals that may serve as leak checker roots.

Alexey Samsonov samsonov at google.com
Thu Sep 26 03:26:06 PDT 2013


On Thu, Sep 26, 2013 at 1:46 PM, Duncan Sands <duncan.sands at gmail.com>wrote:

> Just to clarify this - who should create llvm.gc_root array - do you
>>> suggest to
>>> add a new __attribute__
>>> the user should specify, or to emit llvm.gc_root in frontend,
>>>
>>
>> this one: the front-end would stick globals in the array, for example
>> using the
>> same logic as in isLeakCheckerRoot (but of course it could use different
>> logic
>> if it likes).
>>
>
So, this means pulling isLeakCheckerRoot to the frontend. Nick, WDYT of it
as the author of this function?


>
> PS: Of course one of the advantages of the array approach is that if a user
> specified attribute turns out to be useful, then the front-end can
> implement
> that, or whatever other scheme it likes.
>
> Ciao, Duncan.
>



-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130926/bb351682/attachment.html>


More information about the llvm-commits mailing list