[PATCH] Make Driver::link and LinkingContext::validate return true on success.

Rui Ueyama ruiu at google.com
Tue Sep 24 16:09:58 PDT 2013


This patch inverts the return value of these functions, so that they return
"true" on success and "false" on failure. The meaning of boolean return value
was mixed LLD; for example, InputGraph::validate() return true on success.
With this patch they'll become consistent.

http://llvm-reviews.chandlerc.com/D1748

Files:
  lib/Driver/CoreDriver.cpp
  lib/Driver/DarwinLdDriver.cpp
  lib/Driver/Driver.cpp
  lib/Driver/GnuLdDriver.cpp
  lib/Driver/UniversalDriver.cpp
  lib/Driver/WinLinkDriver.cpp
  lib/ReaderWriter/CoreLinkingContext.cpp
  lib/ReaderWriter/ELF/ELFLinkingContext.cpp
  lib/ReaderWriter/MachO/MachOLinkingContext.cpp
  lib/ReaderWriter/PECOFF/PECOFFLinkingContext.cpp
  lib/ReaderWriter/PECOFF/ReaderCOFF.cpp
  tools/lld/lld.cpp
  unittests/DriverTests/DarwinLdDriverTest.cpp
  unittests/DriverTests/GnuLdDriverTest.cpp
  unittests/DriverTests/WinLinkDriverTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D1748.1.patch
Type: text/x-patch
Size: 45414 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130924/7150c0d6/attachment.bin>


More information about the llvm-commits mailing list