[llvm] r191029 - llvm-c: Make LLVMGetFirstTarget a proper prototype

Anders Waldenborg anders at 0x63.nu
Thu Sep 19 23:26:41 PDT 2013


> > This avoids warnings when included in a application that
> > uses -Wstrict-prototypes.
> >
> 
> Should we enable this warning in CFLAGS for LLVM builds to catch this
> sooner?

It is a C-only warning, and AFAICS there is no C code in that uses
llvm-c in the llvm source tree where this warning could be added.

That said I think it would be good if there was some test for the C
API that compiled and linked againts libLLVM-X.so to make sure that
works properly and there has not sneaked in some c++ in the header
files. Something like c-index-test in clang, but unfortunately I guess
llvm-c is to diverse to be put in a single tool like that.

 anders



More information about the llvm-commits mailing list