[Patch] X86 horizontal vector reduction cost model

Eric Christopher echristo at gmail.com
Thu Sep 19 09:45:48 PDT 2013


Ick. Definitely.

I'll use this as an occasion to plug clang-format. :)

-eric

On Thu, Sep 19, 2013 at 3:42 AM, Tilmann Scheller <tscheller at apple.com> wrote:
> Hi Yi,
>
> minor style nitpick:
>
> +    if (ST->hasSSE42()) {
> +      int Idx = CostTableLookup(SSE42CostTblPairWise, ISD, MTy);
> +      if (Idx != -1)
> +        return LT.first * SSE42CostTblPairWise[Idx].Cost;
> +    }
> +  }
> +  else {
> +    if (ST->hasAVX2()) {
> +      int Idx = CostTableLookup(AVX2CostTblNoPairWise, ISD, MTy);
> +      if (Idx != -1)
> +        return LT.first * AVX2CostTblNoPairWise[Idx].Cost;
> +    }
>
> The else should be on the same line like the closing } of the preceding if.
>
> Regards,
>
> Tilmann
>
> On Sep 18, 2013, at 10:50 PM, yijiang <yjiang at apple.com> wrote:
>
> Hi Arnolds et al.
>
> This patch is to polish horizontal vector reduction cost model for X86
> target. Please help to review it. Thank you.
> <X86-costmodel.patch>
>
>
> -Yi
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list