[PATCH] Under MSVC, supresss warning 4224 and undefine NDEBUG for all release targets

[Aaron Ballman]

On Wed, Sep 18, 2013 at 5:45 PM, Yaron Keren <yaron.keren at gmail.com> wrote:

> Visual C++ 2012 produces warning 4224 nonstandard extension used : formal
> parameter 'type' was previously defined as a type.
>

In what cases does it produce this warning?  How many warnings are produced?


>
> While patching HandleLLVMOptions, I noticed that NDBEUG is removed only
> from the release compile flags but not from the minimum size release or the
> release with debug info.
> With these targets Visual C++ warns about NDEBUG being defined and
> undefined.
>
> The attached patch addresses both issues.
>

Please submit this part as a second patch, this part LGTM.

Thanks!

~Aaron

>
> Yaron
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130919/f3bc9ffc/attachment.html>