[PATCH] request for approval to commit: llvm-c: Fix name of LLVMAddDemoteRegisterToMemoryPass function.

Anders Waldenborg anders at 0x63.nu
Wed Sep 18 12:55:39 PDT 2013


wanders added you to the CC list for the revision "request for approval to commit: llvm-c: Fix name of LLVMAddDemoteRegisterToMemoryPass function.".

Hi echristo,

It has the name reversed (LLVMAddDemoteMemoryToRegisterPass).

The ocaml bindings still have it reversed: llvm_add_memory_to_register_demotion.

http://llvm-reviews.chandlerc.com/D1716

Files:
  bindings/ocaml/transforms/scalar/scalar_opts_ocaml.c
  include/llvm-c/Transforms/Scalar.h
  lib/Transforms/Scalar/Scalar.cpp

Index: bindings/ocaml/transforms/scalar/scalar_opts_ocaml.c
===================================================================
--- bindings/ocaml/transforms/scalar/scalar_opts_ocaml.c
+++ bindings/ocaml/transforms/scalar/scalar_opts_ocaml.c
@@ -106,7 +106,7 @@
 
 /* [<Llvm.PassManager.any] Llvm.PassManager.t -> unit */
 CAMLprim value llvm_add_memory_to_register_demotion(LLVMPassManagerRef PM) {
-  LLVMAddDemoteMemoryToRegisterPass(PM);
+  LLVMAddDemoteRegisterToMemoryPass(PM);
   return Val_unit;
 }
 
Index: include/llvm-c/Transforms/Scalar.h
===================================================================
--- include/llvm-c/Transforms/Scalar.h
+++ include/llvm-c/Transforms/Scalar.h
@@ -105,8 +105,8 @@
 /** See llvm::createConstantPropagationPass function. */
 void LLVMAddConstantPropagationPass(LLVMPassManagerRef PM);
 
-/** See llvm::demotePromoteMemoryToRegisterPass function. */
-void LLVMAddDemoteMemoryToRegisterPass(LLVMPassManagerRef PM);
+/** See llvm::createDemoteRegisterToMemoryPass function. */
+void LLVMAddDemoteRegisterToMemoryPass(LLVMPassManagerRef PM);
 
 /** See llvm::createVerifierPass function. */
 void LLVMAddVerifierPass(LLVMPassManagerRef PM);
Index: lib/Transforms/Scalar/Scalar.cpp
===================================================================
--- lib/Transforms/Scalar/Scalar.cpp
+++ lib/Transforms/Scalar/Scalar.cpp
@@ -164,7 +164,7 @@
   unwrap(PM)->add(createConstantPropagationPass());
 }
 
-void LLVMAddDemoteMemoryToRegisterPass(LLVMPassManagerRef PM) {
+void LLVMAddDemoteRegisterToMemoryPass(LLVMPassManagerRef PM) {
   unwrap(PM)->add(createDemoteRegisterToMemoryPass());
 }
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D1716.1.patch
Type: text/x-patch
Size: 1639 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130918/662805f4/attachment.bin>


More information about the llvm-commits mailing list