[PATCH] Fix LTO handling of module-level assembly (Bug 14152)

[Bill Wendling]

On Sep 13, 2013, at 4:54 PM, Tom Roeder <tmroeder at google.com> wrote:

> Here is a pair of patches that fix and test
> http://llvm.org/bugs/show_bug.cgi?id=14512. The fix applies to LLVM,
> and I have currently put the test in the clang test suite. The test is
> a minor tweak to the test proposed in the bug. Please take a look.
> 
> The problem in this case is that the RecordStreamer implementation of
> MCStreamer in the LTO module doesn't implement EmitCFIEndProcImpl, and
> the default implementation in MCStreamer doesn't finish the frame.
> 
> This patch touches the LTO code in tools/lto, but the test uses clang.
> Is this the right way to do it? Is there a better location for LTO
> tests?
> 
Hi Tom,

I haven't looked at the patch yet. However, the rule-of-thumb for where tests should go is that they should be in located where the code that tests them is. Clang doesn't have anything to do with LTO, so putting it in the clang test suite isn't really good. You'll want to generate a .ll file and place it in the LLVM part. That said, it's hard to know where such a test would go, since we don't really have many for LTO...But just pick a good place that's kind of related. :-)

-bw