[PATCH] [lld][ELF] Fix debug info handling.

Rui Ueyama ruiu at google.com
Fri Sep 13 14:32:57 PDT 2013



================
Comment at: include/lld/Core/DefinedAtom.h:152
@@ -151,2 +151,3 @@
     typeRWNote,             // Identifies readwrite note sections [ELF]
+    typeDebug,
   };
----------------
comment?

================
Comment at: lib/ReaderWriter/ELF/Atoms.h:273
@@ +272,3 @@
+    if (_sectionName.startswith(".debug"))
+      return _contentType = typeDebug;
+
----------------
At first glance it seemed like a typo of == but that's actually correct, and there are the same patterns in this function. But it still feels like a bit confusing...


http://llvm-reviews.chandlerc.com/D1680



More information about the llvm-commits mailing list