Patch to BitcodeReader

[Tobias Grosser]

On 09/12/2013 06:36 PM, Tom Roeder wrote:
> Hi,
>
> Here is a patch that fixes decoding of CE_SELECT in BitcodeReader,
> along with a simple test case. The problem in the current code is that
> it generates but doesn't accept bitcode that uses vectors for the
> first element of a select in this context.  Please let me know what
> you think.

Hi Tom,

nice catch!

The test case does not seem minimal. Is there a reason to not just 
perform the select and return the result? Also, it might be nice to 
check that the disassembler decodes the result correctly. Otherwise this 
test may pass even if it prints out something incorrect, but something 
that does not crash.

Otherwise, the patch looks good to me.

Tobias