[PATCH] Fix the build for git repositories with multiple remotes.

Jordan Rose jordan_rose at apple.com
Thu Sep 12 09:12:33 PDT 2013


On Sep 12, 2013, at 9:07 , Tim Northover <t.p.northover at gmail.com> wrote:

>>  The handling of the output treats it like a single URL. I'd prefer the first remote since the idea is to tell where you are relative to everyone else, and since the GetSourceVersion script only checks the SVN commit number the remote is what's relevant.
> 
> But how's the first remote important? It looks like they're just
> sorted alphabetically by their identifiers. I just don't see how the
> first in that list is ever a sensible answer to "where did it come
> from" except by coincidence.

Most of the name gets chopped up, so all you really get is the branch. That's already dropping plenty of information, of course. The local path may not match one of the forms expected by the processing in Version.cpp.

It's not that the first remote's significant, but that Clang isn't set up to handle multiple paths.

Jordan



More information about the llvm-commits mailing list