[lld] r190554 - Run clang-format.

[Daniel Jasper]

Wait.. We were taking about cases labels .. I think this is significantly
outside of the stuff we have planned to look into.

But there should be no need for you to format entire files. Use our editor
integrations, git-clang-format or our diff-reformatting tool. Then simply
fix these few lines up manually. Should not be a frequent problem, I hope..



On Thu, Sep 12, 2013 at 4:14 AM, Eric Christopher <echristo at gmail.com>wrote:

> For what it's worth Daniel is working on formatting of things like this.
>
> -eric
>
> On Wed, Sep 11, 2013 at 4:29 PM, Rui Ueyama <ruiu at google.com> wrote:
> > I ran clang-format because the file has many indentation errors. I've
> > noticed that that would also change the table layout but I thought that
> that
> > was not really bad.
> >
> > It looks like there's no way to tell clang-format to keep this table
> layout.
> > That means we wouldn't be able to use clang-format on this file, or
> > hand-edit after running clang-format, if we maintain this table layout.
> >
> > I can resurrect the table layout and fix only the indentation errors if
> you
> > want.
> >
> >
> > On Wed, Sep 11, 2013 at 4:19 PM, Nick Kledzik <kledzik at apple.com> wrote:
> >>
> >> The YAML I/O templates are basically tables of how to map yaml keys to
> >> struct fields.
> >> I had all them all carefully aligned into two columns (key and field).
> >> clang-format
> >> went and destroyed all that.
> >>
> >> Is there someway to tell clang-format to not change some formatting?
> >> Or should we just not run clang-format blindly?
> >>
> >> -Nick
> >>
> >> On Sep 11, 2013, at 3:21 PM, Rui Ueyama <ruiu at google.com> wrote:
> >>
> >> -    io.mapRequired("name",      keys->_name);
> >> -    io.mapOptional("ref-name",  keys->_refName, StringRef());
> >> -    io.mapOptional("scope",     keys->_scope);
> >> -    io.mapRequired("value",     keys->_value);
> >> +    io.mapRequired("name", keys->_name);
> >> +    io.mapOptional("ref-name", keys->_refName, StringRef());
> >> +    io.mapOptional("scope", keys->_scope);
> >> +    io.mapRequired("value", keys->_value);
> >>   }
> >>
> >>
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130912/8de9da3b/attachment.html>