[PATCH] [PATCH] Add support for ARMv8 cryptography instructions.

[Tim Northover]

> I'm not sure what you mean. As far as I can tell the MCInsts
> don't have any predicate operands. The decoder namespace
> just ensures that Thumb to ARM conversion is done properly.

The code in ARMDisassembler.cpp that makes use of the "NEONData" space
is followed by calls to functions which add 0xe (== AL) and other
predicate operands to the MCInst.

I think they'll get ignored, but it means the MCInst doesn't match
what you've defined it as. Try "llvm-mc -disassemble -show-inst" and I
think you'll see an instruction different from what you get from
CodeGen or Parsing.

> Good catch. I'll fix that, and similar issues with the SHA instructions.

Were there any SHA errors? I didn't see any so I may have been
misinterpreting the docs.

> As for the tests, I plan to implement the ACLE intrinsics for these so the tests will be included later.

Wouldn't that mean an LLVM patch and Clang patch later, when it could
just be a single Clang patch? We definitely want LLVM code that calls
these intrinsics.

Cheers.

Tim.