[PATCH] [RFC] Deprecated feature in TableGen

[Jim Grosbach]

  This is looking really good. One question and a trivial nitpick below.


================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:7535
@@ -7555,3 +7534,3 @@
   unsigned Opc = Inst.getOpcode();
-  const MCInstrDesc &MCID = getInstDesc(Opc);
+  const MCInstrDesc &MCID = MII.get(Inst.getOpcode());
   if (MCID.TSFlags & ARMII::ThumbArithFlagSetting) {
----------------
Nitpick. Can re-use "Opc" here rather than Inst.getOpcode() again.

================
Comment at: include/llvm/MC/MCInstrDesc.h:173
@@ +172,3 @@
+    if (DeprecatedFeatureMask != 0) {
+      Info = "deprecated";
+      return true;
----------------
Can we have this string reference the name of the subtarget feature that triggered the deprecation?


http://llvm-reviews.chandlerc.com/D1399