[PATCH] [ASan] Remove the function prototypes for intercepted functions on Windows
Alexey Samsonov
samsonov at google.com
Tue Sep 10 07:25:31 PDT 2013
LGTM
================
Comment at: lib/asan/asan_intercepted_functions.h:21
@@ -20,3 +20,3 @@
#include <stdarg.h>
#include <stddef.h>
----------------
Remove these includes
================
Comment at: lib/asan/asan_intercepted_functions.h:24
@@ -23,3 +23,3 @@
using __sanitizer::uptr;
----------------
And this line
================
Comment at: lib/asan/asan_intercepted_functions.h:19
@@ -18,3 +18,3 @@
#include "interception/interception.h"
#include "sanitizer_common/sanitizer_platform_interceptors.h"
----------------
I think you won't need all these includes now (except for sanitizer_common/sanitizer_platform.h). Probably it's fine to merge this file into asan_interceptors.cc (in a separate commit)
http://llvm-reviews.chandlerc.com/D1641
More information about the llvm-commits
mailing list