[PATCH] Address Space Casting

Michele Scandale michele.scandale at gmail.com
Tue Sep 10 04:17:42 PDT 2013


On 09/10/2013 12:55 AM, Eli Friedman wrote:
> What is the change to lib/Target/X86/X86CodeEmitter.cpp doing in the patch?
> 
> The testcases seem a bit lacking... I'd like to see some tests specifically
> testing the new instruction.

Uhm... To be honest I do not know what kind of specific test should I add... The
only thing I see useful is something related to constant folding.

> Please send a note to llvmdev saying that this is close to being committed, with
> a quick description of the new instruction; I want to make sure this isn't a
> surprise to anyone when it gets committed.
> 
> -Eli
> 
> 
> On Sat, Sep 7, 2013 at 9:33 AM, Michele Scandale <michele.scandale at gmail.com
> <mailto:michele.scandale at gmail.com>> wrote:
> 
>       Removed not required forward declaration and include in AutoUpgrade.
> 
>     Hi arsenm, villmow, theraven,
> 
>     http://llvm-reviews.chandlerc.com/D1401
> 
>     CHANGE SINCE LAST DIFF
>       http://llvm-reviews.chandlerc.com/D1401?vs=4102&id=4126#toc
> 
>     Files:
>       docs/LangRef.rst
>       include/llvm-c/Core.h
>       include/llvm/AutoUpgrade.h
>       include/llvm/Bitcode/LLVMBitCodes.h
>       include/llvm/CodeGen/ISDOpcodes.h
>       include/llvm/CodeGen/SelectionDAG.h
>       include/llvm/CodeGen/SelectionDAGNodes.h
>       include/llvm/IR/Constants.h
>       include/llvm/IR/IRBuilder.h
>       include/llvm/IR/Instruction.def
>       include/llvm/IR/Instructions.h
>       include/llvm/InstVisitor.h
>       include/llvm/Target/TargetLowering.h
>       lib/Analysis/ConstantFolding.cpp
>       lib/AsmParser/LLLexer.cpp
>       lib/AsmParser/LLParser.cpp
>       lib/AsmParser/LLToken.h
>       lib/Bitcode/Reader/BitcodeReader.cpp
>       lib/Bitcode/Writer/BitcodeWriter.cpp
>       lib/CodeGen/SelectionDAG/SelectionDAG.cpp
>       lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
>       lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h
>       lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp
>       lib/CodeGen/TargetLoweringBase.cpp
>       lib/IR/AutoUpgrade.cpp
>       lib/IR/ConstantFold.cpp
>       lib/IR/Constants.cpp
>       lib/IR/Core.cpp
>       lib/IR/Instruction.cpp
>       lib/IR/Instructions.cpp
>       lib/IR/Verifier.cpp
>       lib/Target/NVPTX/NVPTXGenericToNVVM.cpp
>       lib/Target/X86/X86CodeEmitter.cpp
>       lib/Target/X86/X86ISelLowering.cpp
>       lib/Target/X86/X86ISelLowering.h
>       test/CodeGen/X86/atomic-dagsched.ll
>       test/DebugInfo/X86/dbg-value-isel.ll
>       test/Other/constant-fold-gep.ll
>       test/Transforms/InstCombine/2009-01-16-PointerAddrSpace.ll
>       test/Transforms/InstCombine/2012-07-30-addrsp-bitcast.ll
>       test/Transforms/InstCombine/cast_ptr.ll
>       test/Transforms/InstCombine/constant-fold-address-space-pointer.ll
>       test/Transforms/InstCombine/gep-addrspace.ll
>       unittests/IR/InstructionsTest.cpp
>       utils/kate/llvm.xml
>       utils/vim/llvm.vim
> 
> 




More information about the llvm-commits mailing list