[PATCH] Add getenv() wrapper that works on multibyte environment variable.

Reid Kleckner rnk at google.com
Mon Sep 9 16:44:19 PDT 2013


  LGTM


================
Comment at: lib/Support/Windows/Process.inc:162
@@ +161,3 @@
+    // Try again with larger buffer.
+    Buf.resize(Buf.size() * 2);
+  }
----------------
Can this be Size + 1?

================
Comment at: lib/Support/Windows/Windows.h:144
@@ -139,1 +143,3 @@
 
+static llvm::error_code UTF8ToUTF16(llvm::StringRef utf8,
+				    llvm::SmallVectorImpl<wchar_t> &utf16) {
----------------
I'd rather leave these out-of-line defined in Path.inc, with declarations here, in some namespace under llvm::, since UTF8ToUTF16 is a common symbol in other codebases.


http://llvm-reviews.chandlerc.com/D1612

BRANCH
  mbenv

ARCANIST PROJECT
  llvm



More information about the llvm-commits mailing list