[PATCH] Proper whole-archive handling

Joerg Sonnenberger joerg at britannica.bec.de
Mon Sep 9 12:31:02 PDT 2013


On Mon, Sep 09, 2013 at 11:41:17AM -0700, Rui Ueyama wrote:
> --force_load seems to be an equivalent to --whole-archive, but I just found
> that the field you just added is not really used at all.

Right, that option is missing, but slightly separate issue.

> 
> Did you forget to add the following code to use the field?
> 
> --- a/lib/Driver/DarwinLdDriver.cpp
> +++ b/lib/Driver/DarwinLdDriver.cpp
> @@ -75,7 +75,7 @@ MachOFileNode::createLinkerInput(const LinkingContext
> &ctx) {
>    auto inputFile(FileNode::createLinkerInput(ctx));
> 
>    if (inputFile)
> -    (*inputFile)->setWholeArchive(false);
> +    (*inputFile)->setWholeArchive(_isWholeArchive);
>    return std::move(inputFile);
>  }

Ah, yes. Left over code...

Joerg



More information about the llvm-commits mailing list