[PATCH] Proper whole-archive handling

Rui Ueyama ruiu at google.com
Mon Sep 9 12:21:49 PDT 2013


I'm submitting the above patch because it seems what it's originally
intended and will fix the warning. This warning is bad because as stated in
the LLVM developer's policy a patch must compile cleanly on at least one
platform.

This clearly demonstrated that the test coverage for the feature is not
sufficient.


On Mon, Sep 9, 2013 at 11:57 AM, Shankar Easwaran
<shankare at codeaurora.org>wrote:

> + Nick
>
> Nick added -all_load option, for making it link darwin style.
>
> Thanks
>
> Shankar Easwaran
>
>
> On 9/9/2013 1:33 PM, Joerg Sonnenberger wrote:
>
>> On Mon, Sep 09, 2013 at 11:28:44AM -0700, Rui Ueyama wrote:
>>
>>>
>>> ================
>>> Comment at: include/lld/Driver/**DarwinInputGraph.h:52
>>> @@ -48,2 +51,3 @@
>>>     const MachOLinkingContext &_ctx;
>>> +  bool _isWholeArchive;
>>>   };
>>> ----------------
>>> This change caused the compiler to warn if -Wunused-private-field is
>>> enabled. I'm going to remove this  line for now for those who enabled
>>> -Werror.
>>>
>> Doesn't Darwin have an equivalent to --whole-archive? -force_load or so
>> with corresponding no option?
>>
>> Joerg
>> ______________________________**_________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/**mailman/listinfo/llvm-commits<http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
>>
>>
>>
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by the Linux Foundation
>
>
> ______________________________**_________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/**mailman/listinfo/llvm-commits<http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130909/78e0c653/attachment.html>


More information about the llvm-commits mailing list