[llvm] r190188 - Debug Info: Move a helper function getTypeIdentifier from DIBuilder to be part

[Manman Ren]

On Fri, Sep 6, 2013 at 11:34 AM, David Blaikie <dblaikie at gmail.com> wrote:

>
>
>
> On Fri, Sep 6, 2013 at 11:27 AM, Manman Ren <manman.ren at gmail.com> wrote:
>
>> Author: mren
>> Date: Fri Sep  6 13:27:00 2013
>> New Revision: 190188
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=190188&view=rev
>> Log:
>> Debug Info: Move a helper function getTypeIdentifier from DIBuilder to be
>> part
>> of DIType.
>>
>> Implement DIType::generateRef to return a type reference. This function
>> will be
>> used in setContaintingType and in DIBuilder to generete the type
>> reference.
>>
>> No functionality change.
>>
>>
>> +    /// Generate a reference to this DIType. Uses the type identifier
>> instead
>> +    /// of the actual MDNode if possible, to help type uniquing.
>> +    DITypeRef generateRef();
>>
>
> 'getTypeRef() const;' perhaps? (open to further/other bikeshedding)
>

I thought about get[Type]Ref(), but it seems that getClassType etc are used
to access fields of the DIType, here we
want to generate a reference to the DIType.
But I am okay with changing it to getTypeRef or generateTypeRef, since we
have isTypeRef already.

Manman


>
>> +
>>      /// replaceAllUsesWith - Replace all uses of debug info referenced by
>>      /// this descriptor.
>>      void replaceAllUsesWith(DIDescriptor &D);
>>      void replaceAllUsesWith(MDNode *D);
>>    };
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130906/6c0e42e6/attachment.html>