[Mesa-dev] [PATCH 1/2] R600/SI: Add isDS helper function to SIInstrInfo

[Michel Dänzer]

On Don, 2013-09-05 at 14:36 -0400, Tom Stellard wrote:
> 
> diff --git a/lib/Target/R600/SILowerControlFlow.cpp b/lib/Target/R600/SILowerControlFlow.cpp
> index a6c43bb..5a8836c 100644
> --- a/lib/Target/R600/SILowerControlFlow.cpp
> +++ b/lib/Target/R600/SILowerControlFlow.cpp

[...]

> @@ -487,9 +492,6 @@ bool SILowerControlFlowPass::runOnMachineFunction(MachineFunction &MF) {
>          case AMDGPU::DS_READ_B32:
>            NeedWQM = true;
>            // Fall through
> -        case AMDGPU::DS_WRITE_B32:
> -        case AMDGPU::DS_ADD_U32_RTN:
> -          NeedM0 = true;
>            break;
>  
>          case AMDGPU::V_INTERP_P1_F32:

This should remove the 'Fall through' comment as well.

LGTM other than that.


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer