[PATCH] Added a new register class for Thumb PC-rel loads

[Daniel Stewart]

I'll see if I can catch it again in a real program. If so, I'll let you know
and we can proceed from there. Thanks.


Daniel

 

From: Renato Golin [mailto:renato.golin at linaro.org] 
Sent: Thursday, September 05, 2013 12:07 PM
To: Daniel Stewart
Cc: Tilmann Scheller; Commits
Subject: Re: [PATCH] Added a new register class for Thumb PC-rel loads

 

On 5 September 2013 15:10, Daniel Stewart <stewartd at codeaurora.org> wrote:

If I cannot find an example that produces mov pc, lr, I am fine with leaving
out the patch, as I can completely understand the need to have tests to show
the effects of & test the patch.

 

I think we really need a fix for a bug like that. There are other ways to
have that tested, for instance, adding a regression test to the test-suite.

 

If you have a full program (or a subset) that presents the problem on
execution, and you can catch that via diff with a gold file, I'd encourage
you to do that, and keep the patch without a test.

 

cheers,

--renato

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130905/c7d47126/attachment.html>