[PATCH] [ARMv8] Implement new operands for DMB/DSB

Tim Northover t.p.northover at gmail.com
Wed Sep 4 11:09:49 PDT 2013


  Could do with some CodeGen tests for those new intrinsics. Other than that I just spotted one possible improvement.


================
Comment at: lib/Target/ARM/ARMInstrInfo.td:4266
@@ -4265,1 +4265,3 @@
 
+def : Pat<(int_arm_dmb (i32 imm:$opt)), (DMB (i32 imm:$opt))>;
+
----------------
Should probably use imm0_15 in the source pattern. An error is better than silently accepting "@llvm.arm.dmb(i32 50)".


http://llvm-reviews.chandlerc.com/D1599



More information about the llvm-commits mailing list