[lld] r189887 - [lld][Driver] The driver was creating linker inputs twice

Shankar Easwaran shankare at codeaurora.org
Tue Sep 3 16:52:05 PDT 2013


Author: shankare
Date: Tue Sep  3 18:52:05 2013
New Revision: 189887

URL: http://llvm.org/viewvc/llvm-project?rev=189887&view=rev
Log:
[lld][Driver] The driver was creating linker inputs twice

Also add a llvm_unreachable call so that the linker will trip on unhandled
inputElement types.

Modified:
    lld/trunk/lib/Driver/Driver.cpp

Modified: lld/trunk/lib/Driver/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/Driver.cpp?rev=189887&r1=189886&r2=189887&view=diff
==============================================================================
--- lld/trunk/lib/Driver/Driver.cpp (original)
+++ lld/trunk/lib/Driver/Driver.cpp Tue Sep  3 18:52:05 2013
@@ -60,7 +60,11 @@ bool Driver::link(const LinkingContext &
         llvm::outs() << fileNode->errStr(error_code(linkerInput)) << "\n";
         return true;
       }
-      linkerInputs.push_back(std::move(*fileNode->createLinkerInput(context)));
+      linkerInputs.push_back(std::move(*linkerInput));
+    }
+    else {
+      llvm_unreachable("Not handling other types of InputElements");
+      return true;
     }
   }
   for (const auto &input : linkerInputs) {





More information about the llvm-commits mailing list