[PATCH] Extend acceptable undefined symbol handling

Rui Ueyama ruiu at google.com
Tue Sep 3 16:20:00 PDT 2013



================
Comment at: include/lld/Core/LinkingContext.h:321
@@ -319,1 +320,3 @@
+  /// of missing undefind symbols.
+  virtual bool outputIsSharedLibrary() const = 0;
   /// @}
----------------
Shankar Kalpathi Easwaran wrote:
> minor nit :- Isnt SharedLibrary an ELF term ? If so, should that be changed to Dynamic library or so 
We are using DynamicLibrary and SharedLibrary interchangeably. Examples are SharedLibraryAtom and SharedLibraryFile. Probably we should choose one (I personally prefer SharedLibrary) and stick to it.


http://llvm-reviews.chandlerc.com/D1582



More information about the llvm-commits mailing list