[lld] r189847 - Finish -rpath implementation to actually create the DT_RPATH entries.

[Joerg Sonnenberger]

On Tue, Sep 03, 2013 at 01:55:53PM -0700, Rui Ueyama wrote:
> On Tue, Sep 3, 2013 at 1:45 PM, Joerg Sonnenberger <joerg at bec.de> wrote:
> > --- lld/trunk/lib/Driver/GnuLdDriver.cpp (original)
> > +++ lld/trunk/lib/Driver/GnuLdDriver.cpp Tue Sep  3 15:45:09 2013
> > @@ -289,6 +289,14 @@ bool GnuLdDriver::parse(int argc, const
> >        break;
> >      }
> >
> > +    case OPT_rpath: {
> > +      SmallVector<StringRef, 2> rpaths;
> > +      StringRef(inputArg->getValue()).split(rpaths, ":");
> > +      for (auto path : rpaths)
> > +        ctx->addRpath(path);
> > +      break;
> > +    }
> >
> 
> Well, you missed my comments as to splitting by ":" may not make much
> sense? Or if it makes sense you should have replied so.

I did:

"-rpath affects the recursive loading of shared libraries, if -rpath-link
is not given. As such I would prefer to have the split path as canonical
value at hand. While this functionality is not implemented yet, it is
certainly on the todo list."

Joerg