[LLD] Cyclic dependency between ReaderWriter and YAML backend

Nick Kledzik kledzik at apple.com
Tue Sep 3 12:53:34 PDT 2013


On Sep 3, 2013, at 12:08 PM, Chandler Carruth <chandlerc at google.com> wrote:
> On Sep 3, 2013 11:57 AM, "Nick Kledzik" <kledzik at apple.com> wrote:
> >
> > Does BUILD_SHARED_LIBS turn every CMake target into a shared library (.so)?    If so, that may be two fine grained.
> >
> > Can BUILD_SHARED_LIBS be detected by CMake and alter the target structure?  For instance moving YAML stuff into Core?
> 
> Not really but if that is the structure you want just make those cmake targets? There is no real reason to have overly fine grained targets
> 
The CMake targets are right now roughly the same as the directory structure.   Very little thought has gone in the CMake target structure.  

> That aside, does YAML stuff really belong in a library called Core? That seems strange to me
> 

The Core layer of knows nothing about file formats and just performs the merge/link of atom graphs.  All testing for the Core layer is done using YAML test cases.   That is why they are “close”.

Joerg has not posted what the circular dependency is.  Maybe it can be fixed by moving some trivial code around.  

-Nick

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130903/1bb79814/attachment.html>


More information about the llvm-commits mailing list