PR1255: Reject commits that turns switch into confusing state

Bob Wilson bob.wilson at apple.com
Tue Sep 3 12:52:41 PDT 2013


The attached patch only touches one file: lib/Transforms/Utils/Local.cpp.  Did you forget to include the rest of it?

I looked through some of your patches and was dismayed to see that you already changed the bit code format.  That's going to make it harder to simply revert all of your changes, since we need to maintain bit code compatibility.  Maybe it would make more sense to push forward and try to complete this project.  What remains to be done and what problems led you give up working on it?

On Sep 2, 2013, at 5:25 AM, Stepan Dyatkovskiy <stpworld at narod.ru> wrote:

> Hi.
> Being implementing PR1255: Case ranges, we stopped in the middle, in very confusing state. These patches reject SwitchInst to stable stage:
> I propose to reject everything related to this issue till the r152532:
> -- Remove IntegersSubset and friends,
> -- Remove SwitchInst::getCaseValueEx (that returns IntegerSubset instance),
> -- Remove IntegerSubsetMapping (reject SelectionDAGBuilder::Clusterify and LowerSwitch::Clusterify).
> 
> 
> 
> Please find first patch in attachment for review.
> 
> Patch rejects changes for local tranformations pass (lib/Tranform/Utils/Local.cpp).
> 
> Revisions that would be rejected for this pass:
> 159076, 157884, 157612, 157576, 157315.
> 
> Thanks.
> 
> -Stepan.
> 
> <Local.patch><Local-rejected-revs.txt>




More information about the llvm-commits mailing list