[llvm] r188297 - Output DW_AT_stmt_list dwarf debug info as DW_FORM_sec_offset instead of DW_FORM_data4 as it is a section offset (fixes the coff/dwarf debug info statement locations)

[Eric Christopher]

On Tue, Sep 3, 2013 at 11:21 AM, Renato Golin <renato.golin at linaro.org> wrote:
> On 3 September 2013 17:14, Eric Christopher <echristo at gmail.com> wrote:
>>
>> I changed the default version on linux to say 4 in r189823. This
>> doesn't hook up well with how the backend is generating code, but they
>> should at least agree.
>
>
> That's one bug down, but still doesn't fix the real issue, that is: Dwarf 3
> consumers can't read LLVM-generated Dwarf.
>
> And for such a small issue, I think this is a rather large side-effect...
>

It's a form that's not understood by whatever old parser you've got.

> Maybe keep this change out until there's a way to specify the Dwarf level?
>

I don't think I want to do this. Basically this will impede ongoing
development to handle issues with old tools that haven't been updated
in ... a long time. I don't have time to get to specifying which forms
per level at the moment and of course all patches are welcome here.
But I don't think it's worth breaking windows debugging just for this.

That said, for this particular one the patch to specify form based on
dwarf version should be straightforward. I'll happily review that.

-eric