[PATCH] [lld][ELF] Add undefined symbol option to lld
Shankar Kalpathi Easwaran
shankarke at gmail.com
Tue Sep 3 11:25:18 PDT 2013
Committed. https://llvm.org/svn/llvm-project/lld/trunk@184266
================
Comment at: include/lld/ReaderWriter/ELFTargetInfo.h:170
@@ +169,3 @@
+ /// linker command line, using the -u option.
+ range<StringRefVectorConstIter> undefinedSymbols() const {
+ return _undefinedSymbols;
----------------
Michael Spencer wrote:
> This should be const StringRef *, vector::iterator is compatible with this.
ok.
================
Comment at: include/lld/ReaderWriter/ELFTargetInfo.h:164-165
@@ +163,4 @@
+ /// Iterators for symbols that appear on the command line
+ typedef std::vector<StringRef>::iterator StringRefVectorIter;
+ typedef std::vector<StringRef>::const_iterator StringRefVectorConstIter;
+ typedef std::vector<StringRef> StringRefVector;
----------------
Michael Spencer wrote:
> These should just be spelled as StringRefVector::{const_,}iterator.
ok.
http://llvm-reviews.chandlerc.com/D997
More information about the llvm-commits
mailing list