[compiler-rt] r189783 - fix PR17061 (and pleeease, don't ask me for a test, this is just a minor output formatting issue :)

[David Blaikie]

On Sep 3, 2013 2:49 AM, "Kostya Serebryany" <kcc at google.com> wrote:
>
> Author: kcc
> Date: Tue Sep  3 04:44:56 2013
> New Revision: 189783
>
> URL: http://llvm.org/viewvc/llvm-project?rev=189783&view=rev
> Log:
> fix PR17061 (and pleeease, don't ask me for a test, this is just a minor
output formatting issue :)

A test case is more than just about how trivial the change is - its also an
indication of how well, or poorly, tested this functionality is in the
general area.

Is there any reason this would be hard to test? Or why the change in
behavior didn't cause existing tests to fail? (Were they just well-written
file check tests? In which case they could be widened a little)

>
> Modified:
>     compiler-rt/trunk/lib/asan/asan_report.cc
>
> Modified: compiler-rt/trunk/lib/asan/asan_report.cc
> URL:
http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_report.cc?rev=189783&r1=189782&r2=189783&view=diff
>
==============================================================================
> --- compiler-rt/trunk/lib/asan/asan_report.cc (original)
> +++ compiler-rt/trunk/lib/asan/asan_report.cc Tue Sep  3 04:44:56 2013
> @@ -118,7 +118,7 @@ static void PrintShadowBytes(const char
>    for (uptr i = 0; i < n; i++) {
>      u8 *p = bytes + i;
>      const char *before = p == guilty ? "[" :
> -        p - 1 == guilty ? "" : " ";
> +        (p - 1 == guilty && i != 0) ? "" : " ";
>      const char *after = p == guilty ? "]" : "";
>      PrintShadowByte(before, *p, after);
>    }
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130903/84bc884b/attachment.html>